Hi Roger
On Wed, 1 Jul 2009, vortexswirling wrote:
> I was concerned about map indexes created by sym_repeat and how they'd
> be resolved to values without being able to specify a map. I see in the
> std_polys code now that a random map is created. Then that would be
> resolved! This would allow pairs of constituents to be colored the same
> (when this type of symmetry occured) and sym_repeat is the only way to
> produce that effect so I would probably chose that for the UC's.
>
> The only thing I see is that with the UC's it wouldn't work to use
> average angle as the coloring method. It seems like it would just use
> apply_cmap in this case.
That is right. Each model type can do its own thing. It is just
coincidental that the current models use the same colouring.
Likewise, for the current models it would be better to overide the
random map with some colours tailored for specific angles to make
the models look nicer. But, for colouring the uniform compounds by
part the random map could be improved by a map to override the first
20 entries with a set of easily differentiated colours.
> In regards to your note about changing e.g. v_coloring to coloring, the
> function color_vef which would be effected by this and is called from
> multiple programs is still in lattice_grid.cc. Ultimately some of the
> lattice_grid code could be split out into more appropriate modules.
I haven't looked at splitting up lattice_grid yet. I had a quick
look at color_vef and the change to a single coloring class will
simplify it slightly by requiring less code.
Adrian.
--
Adrian Rossiter
adrian@...
http://antiprism.com/adrian