Search the web
Sign In
New User? Sign Up
ftpbench · To develop an open-source FTP benchmark application,
? Already a member? Sign in to Yahoo!

Yahoo! Groups Tips

Did you know...
Message search is now enhanced, find messages faster. Take it for a spin.

Best of Y! Groups

   Check them out and nominate your group.
Having problems with message search? Fill out this form to ensure your group is one of the first to be migrated to the new message search system.

Messages

  Messages Help
Advanced
[PATCH] Crash fixes for betaftpd-0.0.8pre17   Message List  
Reply | Forward Message #262 of 282 |
I ran betaftpd under valgrind and stressed it out with
dkftpbench with over 500 users, then killed dkftpbench.
This caused numerous problems to be reported by valgrind.

There were two root causes:

1. list nodes having uninitialized next or prev pointers.
This was simple to fix, just had to always initialize them to 0.
Only alloc_new_conn and alloc_new_ftran needed fixing.

2. parse_command calls command handlers, then unless the handler
returned 0 to indicate a destroyed connection, it references
the connection again. However, many handlers call numeric(),
which can destroy the connection it's being called on.
The "solution" is to make numeric return the same sort of value
that the handlers do, and have the handlers return numeric's
return value. More or less.

Not quite sure if the fix I did was correct, but it doesn't
fail like it used to under my little stress test.
The fix is at
http://kegel.com/dkbetaftpd/betaftpd-numeric.patch





Sat Jun 21, 2003 12:09 am

dankegel
Offline Offline
Send Email Send Email

Forward
Message #262 of 282 |
Expand Messages Author Sort by Date

I ran betaftpd under valgrind and stressed it out with dkftpbench with over 500 users, then killed dkftpbench. This caused numerous problems to be reported by...
dankegel
Offline Send Email
Jun 21, 2003
12:09 am
Advanced

Copyright © 2009 Yahoo! Inc. All rights reserved.
Privacy Policy - Terms of Service - Guidelines - Help