Hi Lincoln, Nick Tonkin is working on the patch to make CGI::Cookie work properly under modperl 2.0 in pre-response handlers, and the issue of providing the...
51130
Stas Bekman
stas@...
Apr 11, 2003 3:35 am
... Done. __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker ...
51131
Nick Tonkin
nick@...
Apr 11, 2003 4:12 am
... D'oh. ... what about eval "require mod_perl"; which never gets checked? ... Eh? You said: if $r is not available, there are a few things to choose from: ...
51132
Nick Tonkin
nick@...
Apr 11, 2003 4:23 am
On Fri, 11 Apr 2003, Stas Bekman wrote:
> Nick Tonkin wrote:
> [...]
>
> Your diff is the other way around, - should say what was removed and + what
> was...
51133
Stas Bekman
stas@...
Apr 11, 2003 4:30 am
... it's checked by 'defined $mod_perl::VERSION' ... that's correct. But since you do: $r || Apache->request the second option is irrelevant. Apache->request...
51134
Stas Bekman
stas@...
Apr 11, 2003 4:40 am
Nick Tonkin wrote: The patch looks good (though I haven't tested it). One thing: [...] ... the only situation when CGI env vars might be unavailable is under...
51135
Stas Bekman
stas@...
Apr 11, 2003 4:47 am
... It can be QUERY_STRING, but not PATH_INFO, since the former is always set, whereas the latter is not: apache-1.3/src/main/util_script.c:381:...
51136
Nick Tonkin
nick@...
Apr 11, 2003 4:49 am
On Fri, 11 Apr 2003, Stas Bekman wrote:
> Nick Tonkin wrote:
>
> The patch looks good (though I haven't tested it). One thing:
>
> [...]
> > + my $r;
> > +...
51137
Nick Tonkin
nick@...
Apr 11, 2003 4:51 am
On Fri, 11 Apr 2003, Stas Bekman wrote:
>
> > > It seemd more logical to test for $ENV{PATH_INFO} than
> > > $ENV{QUERY_STRING}, dunno if you agree.
> >
> >...
51138
Nick Tonkin
nick@...
Apr 11, 2003 4:53 am
... But then does nothing if it's not defined. No graceful handling in other words. Or do I miss something? - nick -- ~~~~~~~~~~~~~~~~~~~~ Nick Tonkin {|8^)>...
51139
Stas Bekman
stas@...
Apr 11, 2003 4:59 am
... Yup, I knew that this will happen. It misses this comment. I've submitted a patch to Lincoln to add this comment. if (exists $ENV{MOD_PERL}) { eval...
51140
Stas Bekman
stas@...
Apr 11, 2003 5:04 am
... Functionalty seems to be alright, I'd just do one last tiny change: + my $raw_cookie; + my $r = shift; + $r ||= eval { Apache->request() } if...
51141
Stas Bekman
stas@...
Apr 11, 2003 5:07 am
... it's set to "". Notice that we check: exists $ENV{QUERY_STRING} may be using REQUEST_METHOD is better. ... which is a wrong assumption I suppose, otherwise...
51142
Nick Tonkin
nick@...
Apr 11, 2003 5:08 am
On Fri, 11 Apr 2003, Stas Bekman wrote:
>
> > +# Fetch a list of cookies from the environment or the incoming headers and
> > +# return as a hash. The cookies...
51143
Stas Bekman
stas@...
Apr 11, 2003 5:14 am
... Great! mp1 has a test which uses CGI::Cookie, so you probably want to test that it works. Also porting the test to mp2's test suite would be great too. ...
51144
Nick Tonkin
nick@...
Apr 11, 2003 5:20 am
... As you can see that's what I went with. - nick -- ~~~~~~~~~~~~~~~~~~~~ Nick Tonkin {|8^)>...
51145
Nick Tonkin
nick@...
Apr 11, 2003 5:22 am
... I don't have mp1 installed here ... and I'm sure done for the night. Not sure when I can get any more mod_perl time ... - nick -- ~~~~~~~~~~~~~~~~~~~~ Nick...
51146
Stas Bekman
stas@...
Apr 11, 2003 5:36 am
... I tested your patch against the mp1 test suite, so we now have Apache->request path tested. ...
51147
Stas Bekman
stas@...
Apr 11, 2003 6:25 am
... Your case still includes things that I don't have, references to some images... can you trim it down to something that can be used as is? it'd be nice to...
51148
Lee Goddard
home@...
Apr 11, 2003 7:16 am
Hi Stas, On Friday, April 11, 2003 at 8:25:09 AM, you wrote: ... SB> Your case still includes things that I don't have, references to some SB> images... can...
51149
Manuel Christen
mchristen@...
Apr 11, 2003 7:51 am
Having problems with mod_perl and Apache::RPC::Server Basically have some perl modules written for RPC::XML::Server to handle XML-RPC methods. I'm now...
51150
Stas Bekman
stas@...
Apr 11, 2003 7:58 am
... You can always inline image using uuencoded or similar ascii friendly encoding. cat /usr/share/doc/perl-IO-stringy-2.108/icons/itembullet.gif | perl -0777...
51151
Stas Bekman
stas@...
Apr 11, 2003 8:05 am
... Ah, similar to header_out, header_in, err_header_out the old API is not supported in 2.0 (the method name is the same though). I've committed a wrapper...
51152
Clinton Gormley
clint@...
Apr 11, 2003 9:52 am
Hi all Sorry - this isn't a mod_perl question, but a lot of you will have experience with this kind of issue. I am building a travel web site which allows you...
51153
Aaron Trevena
aaron.trevena@...
Apr 11, 2003 10:04 am
... You do not need to denormalise - Your objects should have a many to many relationship with attributes, like being vegetarian. This many to many ...
51154
Gareth Kirwan
gbjk@...
Apr 11, 2003 10:08 am
The first thought I had here was VIEW. Gareth ... From: Clinton Gormley [mailto:clint@...] Sent: 11 April 2003 10:42 To: modperl Subject: OT: OO data...
51155
Clinton Gormley
clint@...
Apr 11, 2003 10:25 am
... Admittedly, the minority of searches would specify more than a few attributes, so what you say makes sense - my main concern was having to join loads of...
51156
Nick Tonkin
nick@...
Apr 11, 2003 11:25 am
... As another poster has remarked, why not have your attributes in a separate table? So long as the ID linking them to the main object is not the primary key...
51157
Clinton Gormley
clint@...
Apr 11, 2003 11:56 am
... Thanks Nick That's pretty much what I've got - a table of objects, a table specifying which attributes each object type has, and a series of tables for...
51158
Martin Moss
Martin_moss@...
Apr 11, 2003 12:38 pm
Here's my forpence:- Why Have database Tables Defining which Attributes belong to a Class. Why not Have the attribuites existing in a config section of your...
