Hi,

Still cleaning up the arcanis set, and finally down to this:

Doing a search of 'PRERACE:1' in the whole Arcanis group folder gives me:
339 matches in 39 files.

Any chance this can get a little more debugger friendly?

13:50:30.744 INFO Thread-8 SourceFileLoader:520 Loading game 35e and sources [Player's Guide to Arcanis].
13:50:39.607 SEVERE Thread-8 SourceFileLoader:512 Exception loading files.
java.lang.IllegalArgumentException: PRERACE:1
    at pcgen.cdom.reference.AbstractReferenceManufacturer.getReference(AbstractReferenceManufacturer.java:690)
    at pcgen.rules.context.TrackingManufacturer.getReference(TrackingManufacturer.java:140)
    at pcgen.rules.persistence.TokenUtilities.getTypeOrPrimitive(TokenUtilities.java:66)
    at plugin.lsttokens.add.FeatToken.parseNonEmptyToken(FeatToken.java:175)
    at plugin.lsttokens.add.FeatToken.parseNonEmptyToken(FeatToken.java:56)
    at pcgen.rules.persistence.token.AbstractNonEmptyToken.parseToken(AbstractNonEmptyToken.java:36)
    at pcgen.rules.persistence.TokenSupport.processSubToken(TokenSupport.java:131)
    at pcgen.rules.context.LoadContext.processSubToken(LoadContext.java:256)
    at plugin.lsttokens.AddLst.parseNonEmptyToken(AddLst.java:118)
    at plugin.lsttokens.AddLst.parseNonEmptyToken(AddLst.java:37)
    at pcgen.rules.persistence.token.AbstractNonEmptyToken.parseToken(AbstractNonEmptyToken.java:36)
    at pcgen.rules.persistence.TokenSupport.processToken(TokenSupport.java:62)
    at pcgen.rules.context.LoadContext.processToken(LoadContext.java:262)
    at pcgen.persistence.lst.PCClassLoader.parseClassLevelLine(PCClassLoader.java:316)
    at pcgen.persistence.lst.PCClassLoader.parseFullClassLevelLine(PCClassLoader.java:254)
    at pcgen.persistence.lst.PCClassLoader.processSubLevelLines(PCClassLoader.java:552)
    at pcgen.persistence.lst.PCClassLoader.loadSubLines(PCClassLoader.java:516)
    at pcgen.persistence.SourceFileLoader.loadCampaigns(SourceFileLoader.java:618)
    at pcgen.persistence.SourceFileLoader.loadCampaigns(SourceFileLoader.java:479)
    at pcgen.persistence.SourceFileLoader.execute(SourceFileLoader.java:214)
    at pcgen.gui2.PCGenStatusBar$TaskExecutor.construct(PCGenStatusBar.java:167)
    at pcgen.gui2.PCGenStatusBar$TaskExecutor.construct(PCGenStatusBar.java:130)
    at pcgen.gui2.util.SwingWorker$2.run(SwingWorker.java:146)
    at java.lang.Thread.run(Unknown Source)

--
Andrew Maitland (LegacyKing)
Admin Silverback - PCGen Board of Directors
Data 2nd, Docs Tamarin, OS Lemur
Unique Title "Quick-Silverback Tracker Monkey"
Unique Title "The Torturer of PCGen"

Hi Andrew,

This doesn't answer the wider question, but based on the stack trace, that error looks like it is occurring in association with an ADD:FEAT .

Cheers,
James.

On 6/02/2013 9:11 AM Andrew wrote

Hi,

Still cleaning up the arcanis set, and finally down to this:

Doing a search of 'PRERACE:1' in the whole Arcanis group folder gives me:
339 matches in 39 files.

Any chance this can get a little more debugger friendly?

13:50:30.744 INFO Thread-8 SourceFileLoader:520 Loading game 35e and sources [Player's Guide to Arcanis].
13:50:39.607 SEVERE Thread-8 SourceFileLoader:512 Exception loading files.
java.lang.IllegalArgumentException: PRERACE:1
    at pcgen.cdom.reference.AbstractReferenceManufacturer.getReference(AbstractReferenceManufacturer.java:690)
    at pcgen.rules.context.TrackingManufacturer.getReference(TrackingManufacturer.java:140)
    at pcgen.rules.persistence.TokenUtilities.getTypeOrPrimitive(TokenUtilities.java:66)
    at plugin.lsttokens.add.FeatToken.parseNonEmptyToken(FeatToken.java:175)
    at plugin.lsttokens.add.FeatToken.parseNonEmptyToken(FeatToken.java:56)
    at pcgen.rules.persistence.token.AbstractNonEmptyToken.parseToken(AbstractNonEmptyToken.java:36)
    at pcgen.rules.persistence.TokenSupport.processSubToken(TokenSupport.java:131)
    at pcgen.rules.context.LoadContext.processSubToken(LoadContext.java:256)
    at plugin.lsttokens.AddLst.parseNonEmptyToken(AddLst.java:118)
    at plugin.lsttokens.AddLst.parseNonEmptyToken(AddLst.java:37)
    at pcgen.rules.persistence.token.AbstractNonEmptyToken.parseToken(AbstractNonEmptyToken.java:36)
    at pcgen.rules.persistence.TokenSupport.processToken(TokenSupport.java:62)
    at pcgen.rules.context.LoadContext.processToken(LoadContext.java:262)
    at pcgen.persistence.lst.PCClassLoader.parseClassLevelLine(PCClassLoader.java:316)
    at pcgen.persistence.lst.PCClassLoader.parseFullClassLevelLine(PCClassLoader.java:254)
    at pcgen.persistence.lst.PCClassLoader.processSubLevelLines(PCClassLoader.java:552)
    at pcgen.persistence.lst.PCClassLoader.loadSubLines(PCClassLoader.java:516)
    at pcgen.persistence.SourceFileLoader.loadCampaigns(SourceFileLoader.java:618)
    at pcgen.persistence.SourceFileLoader.loadCampaigns(SourceFileLoader.java:479)
    at pcgen.persistence.SourceFileLoader.execute(SourceFileLoader.java:214)
    at pcgen.gui2.PCGenStatusBar$TaskExecutor.construct(PCGenStatusBar.java:167)
    at pcgen.gui2.PCGenStatusBar$TaskExecutor.construct(PCGenStatusBar.java:130)
    at pcgen.gui2.util.SwingWorker$2.run(SwingWorker.java:146)
    at java.lang.Thread.run(Unknown Source)

--
Andrew Maitland (LegacyKing)
Admin Silverback - PCGen Board of Directors
Data 2nd, Docs Tamarin, OS Lemur
Unique Title "Quick-Silverback Tracker Monkey"
Unique Title "The Torturer of PCGen"

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/565/changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/566/changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/570/changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/571/changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/572/changes>

Hi Folks!

I have finally added the SPELLPOINTCOST tag to the docs but I am uncertain if I
have captured it correctly. The final proposal was never recapped and I'm not
sure if I followed the intent presented during the discussion. I also plowed
through the code and at least verified that the TOTAL=x syntax was implemented
along with what showes up in the DOC tracker.

Tom or James, or any other Code Monkey that has time or the inclination, can you
look at the SPELLPOINTCOST tag docs and see if it properly describes what the
code does? I have included a link to the JIRA for this DOC work.

http://jira.pcgen.org/browse/DOCS-56#comment-17858

There are a number of CODE trackers waiting for the tag docs to catch up.

Thanks!

Maredudd
Doc 2nd

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/573/changes>

This will be my last update for a while: I'm shelving my Android port of PCGen
for now. I got it to the point where it would load and render a PC. However,
it's about a factor of 100 too slow for real-world use (7 minutes on my tablet,
35 minutes on my phone). I think it might be possible to achieve that factor of
100 with lots of caching and trimmed-down loading, but it's too much work for my
hobby programming hours so I'm stopping. Realistically, the whole approach to
LST parsing would need to be revisited (and perhaps database-driven as has been
discussed on this list).

If anyone else wants to pick up my work, my two git repos are here:
    https://github.com/chrisdolan/pcgen-svn
    https://github.com/chrisdolan/pcgen-android

Many of my changes, especially in my "interned_strings" branch, would be useful
for the desktop PCGen too. With those changes I achieved a speedup of 2x on my
Mac before I quit, largely because of reduced garbage collection time.

I would be very happy to answer any questions about my research. And if someone
were to make a breakthrough, I'd be thrilled to jump back into the project.

Chris

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/574/changes>

Sorry to hear that, hopefully your improvements can help the desktop version
though, and fingers crossed somebody can look into the other improvements.

Fully understand the issues with not enough time...

--- In pcgen_developers@yahoogroups.com, Chris Dolan <chris@...> wrote:
>
> This will be my last update for a while: I'm shelving my Android port of PCGen
for now. I got it to the point where it would load and render a PC. However,
it's about a factor of 100 too slow for real-world use (7 minutes on my tablet,
35 minutes on my phone). I think it might be possible to achieve that factor of
100 with lots of caching and trimmed-down loading, but it's too much work for my
hobby programming hours so I'm stopping. Realistically, the whole approach to
LST parsing would need to be revisited (and perhaps database-driven as has been
discussed on this list).
>
> If anyone else wants to pick up my work, my two git repos are here:
>    https://github.com/chrisdolan/pcgen-svn
>    https://github.com/chrisdolan/pcgen-android
>
> Many of my changes, especially in my "interned_strings" branch, would be
useful for the desktop PCGen too. With those changes I achieved a speedup of 2x
on my Mac before I quit, largely because of reduced garbage collection time.
>
> I would be very happy to answer any questions about my research. And if
someone were to make a breakthrough, I'd be thrilled to jump back into the
project.
>
> Chris
>

See
<http://ci.pcgen.org/jenkins/job/PCGen%20Trunk/net.sourceforge.pcgen$pcgen/3558/\
changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Trunk/3558/changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Trunk/3559/changes>

See
<http://ci.pcgen.org/jenkins/job/PCGen%20Trunk/net.sourceforge.pcgen$pcgen/3559/\
changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/changes>

Just two quick questions

1) What is the difference between the various unit test categories we
have: code/src/test vs. code/src/utest vs. code/src/itest?

2) Can I create a simple test case to calculate a character's CR without
having to provide a full pcg file? I.e. create a character, set race and
levels via code?

Regards
Stefan

Just two quick questions
1) What is the difference between the various unit test categories we
have: code/src/test vs. code/src/utest vs. code/src/itest?

• code/src/test - general tests that may have a wide range of dependencies per test. This is our original test folder
• code/src/utest - Quick single function unit tests with low dependencies. These are the ones that get run on the default ant build. Any tests here should not need the plugin jars loaded or the spring container initiated. They should also be able to be run in a single JVM (so not have side effects).
• code/src/itest - Integration tests - these are tests that verify the end to end behaviour of areas of the code, particularly the CDOM code. They normally require the spring container and the plugins to be loaded. As a result they run in a separate JVM per test and are slower than other tests.
• code/src/testcommon - This is a set of dependencies which may be used in any other test. It is used because maven will not see files in one tests folder/category when running the tests from a different folder.
  

2) Can I create a simple test case to calculate a character's CR without
having to provide a full pcg file? I.e. create a character, set race and
levels via code?

--- In pcgen_developers@yahoogroups.com, James Dempsey <jdempsey@...> wrote:
>   * code/src/utest - Quick single function unit tests with low
>     dependencies. These are the ones that get run on the default ant
>     build. Any tests here should not need the plugin jars loaded or the
>     spring container initiated. They should also be able to be run in a
>     single JVM (so not have side effects).

In general these would be tests that are checking one class (though it may rely
on others as a side effect).  As a result, these tests are generally lined up in
the package with the class they are testing.  Alternatively, they are in a
package identifying the interface of the class being tested (e.g.
selectionactor) [The separate unit testing per interface allows us to better
extend base classes to share test code]

>   * code/src/itest - Integration tests - these are tests that verify the
>     end to end behaviour of areas of the code, particularly the CDOM
>     code. They normally require the spring container and the plugins to
>     be loaded. As a result they run in a separate JVM per test and are
>     slower than other tests.

In general, these are testing integration of entire subsystems or
cross-subsystem behavior.  The package name thus often an identification of the
subsystems being tested together (e.g. tokenmodel tests links from parsing the
tokens to loading the data into the in-memory character model.)

> > 2) Can I create a simple test case to calculate a character's CR without
> > having to provide a full pcg file? I.e. create a character, set race and
> > levels via code?
>
> Yes, you will want to create a new test class that extends
> AbstractCharacterTestCase. See pcgen.core.PlayerCharacterSpellTest for
> an example. You will most likely want to put this sort of test in
> code/src/test.

Such a test definitely belongs in code/src/test :)

Another alternative is to directly inject the required facts and test the
output.  This depends on what you are trying to achieve in a given test... but
if you really want the full object in to output token type test, then what James
describes is probably best.

The smallest test is if you are attempting to check just the calculation of
CRFacet. That has not yet been done and would be placed in
/utest/pcgen.cdom.facet.analysis.CRFacetTest.java

The integration test would for /itest/ should eventually be something like a
modeloutput package, and would be the appropriate place for testing something
like CR from the various possible change locations (Race, Template, BONUS, etc.)
through to the output token.

(Note there is probably never a tokenmodel test for something like CR since it
is already very basic in being a number/formula.  So the token tests in the
utest directory already perform what would be the equivalent of the tokenmodel
tests for CR.  If you look closely, the tokenmodel tests that are there are all
tokens that perform an "allow" or "grant" of an object, not just act as a holder
of a "fact" (CR, Hands, etc.).  All of the "facts" that interact will eventually
need something like the modelanalysis itest.  Note also that the "allow",
"grant" and "fact" statements are the keywords I'm using here:
http://wiki.pcgen.org/LST_Token_Information which is the page I'm using to help
track my development of such unit tests.)

TP.

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/changes>

Thanks, Tom and James, that was very helpful. I was able to create a
test class in code/src/test that goes through various character setups
and tests the calculated CRs as well as the loader code for the involved
tags.

I'm still getting used to unit tests. Very nice.

Regards
Stefan

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/changes>
------------------------------------
Yahoo! Groups Links
<*> To visit your group on the web, go to:
http://groups.yahoo.com/group/pcgen_developers/
<*> Your email settings:
Individual Email | Traditional
<*> To change settings online go to:
http://groups.yahoo.com/group/pcgen_developers/join
(Yahoo! ID required)
<*> To change settings via email:
pcgen_developers-digest@yahoogroups.com pcgen_developers-fullfeatured@yahoogroups.com
<*> To unsubscribe from this group, send an email to:
pcgen_developers-unsubscribe@yahoogroups.com
<*> Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/changes>

Hi,

Do we know why these two unit tests are failing? One seems to be the Alternating HP issue; the other seems to be HD changing from -3 to +3???

On 2/22/2013 1:46 PM, hudson@... wrote:

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/changes>
------------------------------------
Yahoo! Groups Links
<*> To visit your group on the web, go to:
http://groups.yahoo.com/group/pcgen_developers/
<*> Your email settings:
Individual Email | Traditional
<*> To change settings online go to:
http://groups.yahoo.com/group/pcgen_developers/join
(Yahoo! ID required)
<*> To change settings via email:
pcgen_developers-digest@yahoogroups.com pcgen_developers-fullfeatured@yahoogroups.com
<*> To unsubscribe from this group, send an email to:
pcgen_developers-unsubscribe@yahoogroups.com
<*> Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/

--
Andrew Maitland (LegacyKing)
Admin Silverback - PCGen Board of Directors
Data 2nd, Docs Tamarin, OS Lemur
Unique Title "Quick-Silverback Tracker Monkey"
Unique Title "The Torturer of PCGen"

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/578/changes>

See <http://ci.pcgen.org/jenkins/job/PCGen%20Full%20Tests/579/changes>