Welcome aboard Mark!

The James/Tom/Connor combo should be in touch shortly :)

K

> Hi Mark!
>
> Welcome to the project. James should be on later and bring you up to speed. In
the meantime a good spot to check out the team is here:
> http://wiki. pcgen.org/ index.php? title=Joining_ the_Code_ Team
> http://wiki. pcgen.org/ index.php? title=Code_ Monkey_Introduction
> http://wiki. pcgen.org/ index.php? title=Basic_ Developer_ Setup
>
> Note that these wiki pages are in need of an update, but are still accurate
enough to start with.
>
> Once again, welcome. If you have any questions, don't hesistate to ask.
>
> -Andrew
>
>
>
> ________________________________
> From: "motorviper@..." <motorviper@...>
> To: pcgen_developers@yahoogroups.com
> Sent: Thursday, September 24, 2009 12:52:22 PM
> Subject: [pcgen_developers] Another new guy,
>
>  
> Hi, I'm Mark (online name MotorViper) and I'm a new volunteer. My speciality
is user interface work so it was suggested that I talk to James and/or Tom to
get details on the user interface makeover and get an introduction to Connor.
Apologies for any protocol blunders I make on the group but, even though I've
been a programmer for over 25 years, this is the first time I've joined a group
like this!
>
> MotorViper.
>

Connor,

I don't have any particular area that I'm most interested in, I'm open
to suggestions as to where you'd find me most useful. I've got a lot of
experience in UI design and coding but must admit my Java's a little
rusty as I've been coding C# and C++ for the last 5 years. If I'm
pointed at something to do I'll have a go.

Mark.

Connor Petty wrote:
>
>
> Welcome Mark!
> Sorry about the sluggish reply, I was hoping Tom or James would
> respond first, but either they are a little preoccupied or they wanted
> me to respond first. Anyway before I give you all the details about
> the UI work that is going on and what needs to be done I think you
> should talk to James or Tom about adding you to the project first.
> They should be posting shortly...I think. School just started for me
> so my participation in PCGen might be a little scarce for the next
> couple weeks. But I'll try to help you along as much as I can with
> what free time I have. Any help is appreciated, especially on the UI
> development.
>
> Just out of curiosity, is there any part of PCGen's UI that you have a
> particular interest in?
>
> -Connor Petty
>
> On Fri, Sep 25, 2009 at 2:25 AM, karianna03 <martijnverburg@...
> <mailto:martijnverburg@...>> wrote:
>
>
>
>     Welcome aboard Mark!
>
>     The James/Tom/Connor combo should be in touch shortly :)
>
>     K
>
>
>
>     > Hi Mark!
>     >
>     > Welcome to the project. James should be on later and bring you
>     up to speed. In the meantime a good spot to check out the team is
>     here:
>     > http://wiki. pcgen.org/ <http://pcgen.org/> index.php?
>     title=Joining_ the_Code_ Team
>     > http://wiki. pcgen.org/ <http://pcgen.org/> index.php?
>     title=Code_ Monkey_Introduction
>     > http://wiki. pcgen.org/ <http://pcgen.org/> index.php?
>     title=Basic_ Developer_ Setup
>     >
>     > Note that these wiki pages are in need of an update, but are
>     still accurate enough to start with.
>     >
>     > Once again, welcome. If you have any questions, don't hesistate
>     to ask.
>     >
>     > -Andrew
>     >
>     >
>     >
>     > ________________________________
>     > From: "motorviper@..." <motorviper@...>
>
>     > To: pcgen_developers@yahoogroups.com
>     <mailto:pcgen_developers%40yahoogroups.com>
>     > Sent: Thursday, September 24, 2009 12:52:22 PM
>     > Subject: [pcgen_developers] Another new guy,
>     >
>     >
>     > Hi, I'm Mark (online name MotorViper) and I'm a new volunteer.
>     My speciality is user interface work so it was suggested that I
>     talk to James and/or Tom to get details on the user interface
>     makeover and get an introduction to Connor. Apologies for any
>     protocol blunders I make on the group but, even though I've been a
>     programmer for over 25 years, this is the first time I've joined a
>     group like this!
>     >
>     > MotorViper.
>     >
>
>
>
> ------------------------------------------------------------------------
>
>
> No virus found in this incoming message.
> Checked by AVG - www.avg.com
> Version: 8.5.409 / Virus Database: 270.13.112/2392 - Release Date: 09/24/09
05:52:00
>
>

--- In pcgen_developers@yahoogroups.com, Connor Petty <mistercpp2000@...> wrote:
> The foundation for this new UI Editors is not
> yet complete and some of it requires a bit of discussion between James, Tom,
> and I before it can be finished.


Err, what didn't we cover in the last code team meeting?  Can we cover it here
on the list or do you think it's a lengthy discussion that we should do during
the Oct code team meeting?

TP.

Welcome, Mark!

Apologies for my lag in responding - the last week of a calendar quarter can get
a bit crazy for me.

Do you prefer Mark or MotorViper (or doesn't it matter)?

I see Drew has already pointed you to the start-up docs.  About the only major
change is that we have made some changes to adding new members to the code team.
We are now starting off new members by asking they submit either a patch or a
proposal. Once that is accepted we'll add you to the project and give you commit
access.

I also see you've connected with Connor and he has introduced the different
UI-based projects that are in planning (LST Editor) or underway (the gui2 work
Connor is doing)

Have you built any of your own data for PCGen?  While not necessary for the LST
Editor work, it would be a huge boost.

As far as simple bugs, there only seems to be one UI related one at the moment:
http://sourceforge.net/tracker/?func=detail&aid=2848655&group_id=25576&atid=3847\
19

This is a need for a scroll bar in the HP adjustment window accessible from our
Summary Screen.

Another possibility is looking at our purchase mode system (how you select
starting stats for a PC) and rebuild that system.  There are at least two FREQs
related to this:
https://sourceforge.net/tracker/?func=detail&aid=1958856&group_id=25576&atid=384\
722
https://sourceforge.net/tracker/?func=detail&aid=1958858&group_id=25576&atid=384\
722

This may be a good option as it's not related to code that others are changing
in any of the major ongoing projects.

So that provides a few more options for you.  Let us know what sounds
interesting.

TP.

No problems about lag, I suffer from that a lot myself :). As for name either
Mark or MotorViper will be fine, I'll answer to both or just about anything
else. As I have said to Tom, the LST editor sounds interesting, but then so does
the other stuff. I'm happy, at the moment at least while I get my feet, fitting
in wherever I'm needed.

I'm looking at the HP screen resize problem at the moment to get my min back
onto Java after a couple of years break.

Fixed the error mentioned below:

http://sourceforge.net/tracker/?func=detail&aid=2848655&group_id=25576&atid=3847\
\19

What's the procedure for getting this admitted. It's probably in the Wiki but I
can't find it.

 

Fixed the error mentioned below:

http://sourceforge.net/tracker/?func=detail&aid=2848655&group_id=25576&atid=3847\19

What's the procedure for getting this admitted. It's probably in the Wiki but I can't find it.

-- Andrew Maitland (LegacyKing)
Admin Silverback, PCGen Board of Directors Data Chimp, Docs Tamarin
Unique Title "Quick-Silverback Tracker Monkey"

I thought I'd already sent this but just to make sure. I've uploaded the patch,
it's MV_Main_HP_patch.txt.

--- In pcgen_developers@yahoogroups.com, Andrew Maitland <drew0500@...> wrote:
>
> motorviper@... wrote:
>
> Upload a patch to the files section of the group so Tom can check it
> out. If it looks good then he'll give you commit access.
>
> Which BTW, we will need your SF name to grant.

Hi Andrew, any luck?

> I will be looking at this, hopefully before the weekend.
>
> andrew
>
> 2009/9/16 karianna03 <martijnverburg@...>:
> > I've updated this for the latest Eclipse 3.5 settings.
> >
> > K
> >
> >> I have placed the table on the Wiki here:
> >> http://wiki.pcgen.org/index.php?title=Coding_Standards
> >>
> >> Andrew, can you fill in IDEA?
> >> Connor, can you fill in NetBeans?
> >>
> >> TP.
> >> --
> >>
> >> Tom Parker
> >>
> >> thpr@ and tppublic@
> >>
> >> --- On Wed, 9/9/09, Andrew Wilson <andrew@> wrote:
> >>
> >> From: Andrew Wilson <andrew@>
> >> Subject: Re: [pcgen_developers] Re: Other potential cleanup in AbilityToken
> >> To: pcgen_developers@yahoogroups.com
> >> Date: Wednesday, September 9, 2009, 6:51 AM
> >>
> >> 2009/9/9 karianna03 <martijnverburg@>:
> >> > Alternatively we could write the rules into the Maven build?  Maven
supports various plugins
> >> > for checkstyle, findbugs, PMD etc, it does mean we need to organise
displaying the maven
> >> > site and encouraging developers to look at the results of those tools.
> >>
> >> That means you have to leave your editor to find the problems.  It's a
> >> lot easier to deal with if
> >> this stuff if your editor tells you about when you open a file.
> >> Having to go to a web site to
> >> find the problems is effectively adding another tool, silimar to
> >> having to load the code in several
> >> editors.  I'm not greatly taken with that idea.
> >>
> >> I think we should start with at least the eclipse column of the table
> >> Tom mentioned, see what
> >> we think are reasonable things.  Then if anybody wants to use a
> >> different tool they can fill in
> >> their column of the table.  I think we need to know:
> >>
> >> 1. What clean ups do we want
> >> 2. which of them can the various editors support.
> >>
> >> If it turns out that everything we'd like is supported by all the
> >> tools currently being used, then
> >> we have a reasonably easy time.  i don't think we can make sensible
> >> decisions without the info.
> >>
> >> andrew
> >>
> >>
> >> ------------------------------------
> >>
> >> Yahoo! Groups Links
> >>
> >
> >
> >
> >
> > ------------------------------------
> >
> > Yahoo! Groups Links
> >
> >
> >
> >
>

My machine died before I got a chance to fill that in.  I don't currently have a
machine with IDEA installed on it.  I have a crappy machine that is barely
capable of web browsing and email.  My new machine should be arriving
this week sometime, then I need to get it back into a useable state.

Will fill this in, hopefully soon.

andrew

2009/9/28 karianna03 <martijnverburg@...>:
> Hi Andrew, any luck?
>
>> I will be looking at this, hopefully before the weekend.
>>
>> andrew
>>
>> 2009/9/16 karianna03 <martijnverburg@...>:
>> > I've updated this for the latest Eclipse 3.5 settings.
>> >
>> > K
>> >
>> >> I have placed the table on the Wiki here:
>> >> http://wiki.pcgen.org/index.php?title=Coding_Standards
>> >>
>> >> Andrew, can you fill in IDEA?
>> >> Connor, can you fill in NetBeans?
>> >>
>> >> TP.
>> >> --
>> >>
>> >> Tom Parker
>> >>
>> >> thpr@ and tppublic@
>> >>
>> >> --- On Wed, 9/9/09, Andrew Wilson <andrew@> wrote:
>> >>
>> >> From: Andrew Wilson <andrew@>
>> >> Subject: Re: [pcgen_developers] Re: Other potential cleanup in
AbilityToken
>> >> To: pcgen_developers@yahoogroups.com
>> >> Date: Wednesday, September 9, 2009, 6:51 AM
>> >>
>> >> 2009/9/9 karianna03 <martijnverburg@>:
>> >> > Alternatively we could write the rules into the Maven build?  Maven
supports various plugins
>> >> > for checkstyle, findbugs, PMD etc, it does mean we need to organise
displaying the maven
>> >> > site and encouraging developers to look at the results of those tools.
>> >>
>> >> That means you have to leave your editor to find the problems.  It's a
>> >> lot easier to deal with if
>> >> this stuff if your editor tells you about when you open a file.
>> >> Having to go to a web site to
>> >> find the problems is effectively adding another tool, silimar to
>> >> having to load the code in several
>> >> editors.  I'm not greatly taken with that idea.
>> >>
>> >> I think we should start with at least the eclipse column of the table
>> >> Tom mentioned, see what
>> >> we think are reasonable things.  Then if anybody wants to use a
>> >> different tool they can fill in
>> >> their column of the table.  I think we need to know:
>> >>
>> >> 1. What clean ups do we want
>> >> 2. which of them can the various editors support.
>> >>
>> >> If it turns out that everything we'd like is supported by all the
>> >> tools currently being used, then
>> >> we have a reasonably easy time.  i don't think we can make sensible
>> >> decisions without the info.
>> >>
>> >> andrew
>> >>
>> >>
>> >> ------------------------------------
>> >>
>> >> Yahoo! Groups Links
>> >>
>> >
>> >
>> >
>> >
>> > ------------------------------------
>> >
>> > Yahoo! Groups Links
>> >
>> >
>> >
>> >
>>
>
>
>
>
> ------------------------------------
>
> Yahoo! Groups Links
>
>
>
>

Hey Guys-
So, went to start squashing bugs, and as part of my first step, I updated to the
HEAD of SVN. Now, I have build errors out of the box. It looks like a new jar
was added to the checked-in Eclipse project for lib/spring-core.jar. This file
does not exist, so Eclipse complains that it can't find all its required jars.

It looks like James checked this change to the classpath in this last week, but
did not add the spring-core.jar to the lib folder. Was this accidental, or am I
the only one having this issue?
--

Steven west

I'm having trouble loading up most of my pcg files recently. I use the "load
sources from pcg file" mode, and the pcg file has the needes sources listed in
a CAMPAIGN tag line. This has now ceased to work, as objects that are not
defined in the first listed campaign are no longer loaded and show up as
unknown.

Any idea what caused this?

Regards,
Stefan.

Should be working now.

--- In pcgen_developers@yahoogroups.com, "redwolfe3" <yahoo_groups@...> wrote:
>
> Hey Guys-
> So, went to start squashing bugs, and as part of my first step, I updated to
the HEAD of SVN. Now, I have build errors out of the box. It looks like a new
jar was added to the checked-in Eclipse project for lib/spring-core.jar. This
file does not exist, so Eclipse complains that it can't find all its required
jars.
>
> It looks like James checked this change to the classpath in this last week,
but did not add the spring-core.jar to the lib folder. Was this accidental, or
am I the only one having this issue?
> --
>
> Steven west
>

--- In pcgen_developers@yahoogroups.com, "motorviper@..." <motorviper@...>
wrote:
>
> I thought I'd already sent this but just to make sure. I've uploaded the
patch, it's MV_Main_HP_patch.txt.

I see it - I'll take a look tonight

TP.

--- In pcgen_developers@yahoogroups.com, "motorviper@..." <motorviper@...>
wrote:
>
> I thought I'd already sent this but just to make sure. I've uploaded the
patch, it's MV_Main_HP_patch.txt.
>

Mark,

Looks good.

What's your SourceForge ID?  I will add you to the project, and then you can
check in the change.

Thanks

TP.

SourceForge ID is motorviper.

--- In pcgen_developers@yahoogroups.com, "thpr" <thpr@...> wrote:
>
> --- In pcgen_developers@yahoogroups.com, "motorviper@" <motorviper@> wrote:
> >
> > I thought I'd already sent this but just to make sure. I've uploaded the
patch, it's MV_Main_HP_patch.txt.
> >
>
> Mark,
>
> Looks good.
>
> What's your SourceForge ID?  I will add you to the project, and then you can
check in the change.
>
> Thanks
>
> TP.
>

Cool!  Great to see another fix come in :).  When Tom has added you please don't
hesitate to add yourself to the Team Wiki (Full Team List and Code Team List).

Welcome aboard!

K

> SourceForge ID is motorviper.
>
> --- In pcgen_developers@yahoogroups.com, "thpr" <thpr@> wrote:
> >
> > --- In pcgen_developers@yahoogroups.com, "motorviper@" <motorviper@> wrote:
> > >
> > > I thought I'd already sent this but just to make sure. I've uploaded the
patch, it's MV_Main_HP_patch.txt.
> > >
> >
> > Mark,
> >
> > Looks good.
> >
> > What's your SourceForge ID?  I will add you to the project, and then you can
check in the change.
> >
> > Thanks
> >
> > TP.
> >
>

I found the problem. It happens only with Pathfinder data sets, and the error
was that the PCC files still had GAMEMODE:Pathfiner, but the game mode name
has changed. I'm committing a fix.

Stefan.

On Monday 28 September 2009 16:04:38 Stefan Radermacher wrote:
> I'm having trouble loading up most of my pcg files recently. I use the
>  "load sources from pcg file" mode, and the pcg file has the needes sources
>  listed in a CAMPAIGN tag line. This has now ceased to work, as objects
>  that are not defined in the first listed campaign are no longer loaded and
>  show up as unknown.
>
> Any idea what caused this?
>
> Regards,
> Stefan.
>

Mark,

I've added you to the project on SourceForge, so please go ahead and commit your
change.

You should also be able to assign the tracker to yourself and mark that as
implemented.

Please also make sure to add your name to the code monkeys list in
PCGenProp.properties

Thanks again for the fix!

TP.

I just saw this after I sent you a personal message about that commit,
now I understand why you did that. So the GAMEMODE tag needs to match
the gameMode folder name or it breaks the load pcc sources function? Is
there a way to fix this in the code rather than limit ourselves to
making these match? This means Legends_of_Excalibur also will have this
problem (GAMEMODE:LoE) and what happens when there are multiples in
ALOWEDMODES like in xCrawl (ALLOWEDMODES:3e|DnD|Xcrawl).

In any case if this is the solution you need to also change the gameMode
file.

Stefan Radermacher wrote:
> I found the problem. It happens only with Pathfinder data sets, and the error
> was that the PCC files still had GAMEMODE:Pathfiner, but the game mode name
> has changed. I'm committing a fix.
>
> Stefan.
>
> On Monday 28 September 2009 16:04:38 Stefan Radermacher wrote:
>
>> I'm having trouble loading up most of my pcg files recently. I use the
>>  "load sources from pcg file" mode, and the pcg file has the needes sources
>>  listed in a CAMPAIGN tag line. This has now ceased to work, as objects
>>  that are not defined in the first listed campaign are no longer loaded and
>>  show up as unknown.
>>
>> Any idea what caused this?
>>
>> Regards,
>> Stefan.
--
~ Eddy Anthony (MoSaT)
~ PCGen Board of Directors
~ Content Silverback, Chair Second

I traced the code trying to find out why it wouldn't load my data sets. For
each data set defined on the CAMPAIGN line of the character the parser checks
the game mode defined in that data set's PCC file against the current game
mode. This is the condition used:

aCampaign.containsInList(
   ListKey.GAME_MODE,
   SettingsHandler.getGame().getName()
)

As far as I can say, it only checks against the real name of the game mode. In
my case the current game mode was "Pathfinder_RPG", and the data sets had just
"Pathfinder" in them, and were not loaded because these didn't match.

Stefan.

On Tuesday 29 September 2009 15:14:53 Eddy Anthony wrote:
> I just saw this after I sent you a personal message about that commit,
> now I understand why you did that. So the GAMEMODE tag needs to match
> the gameMode folder name or it breaks the load pcc sources function? Is
> there a way to fix this in the code rather than limit ourselves to
> making these match? This means Legends_of_Excalibur also will have this
> problem (GAMEMODE:LoE) and what happens when there are multiples in
> ALOWEDMODES like in xCrawl (ALLOWEDMODES:3e|DnD|Xcrawl).
>
> In any case if this is the solution you need to also change the gameMode
> file.
>
> Stefan Radermacher wrote:
> > I found the problem. It happens only with Pathfinder data sets, and the
> > error was that the PCC files still had GAMEMODE:Pathfiner, but the game
> > mode name has changed. I'm committing a fix.
> >
> > Stefan.
> >
> > On Monday 28 September 2009 16:04:38 Stefan Radermacher wrote:
> >> I'm having trouble loading up most of my pcg files recently. I use the
> >>  "load sources from pcg file" mode, and the pcg file has the needes
> >> sources listed in a CAMPAIGN tag line. This has now ceased to work, as
> >> objects that are not defined in the first listed campaign are no longer
> >> loaded and show up as unknown.
> >>
> >> Any idea what caused this?
> >>
> >> Regards,
> >> Stefan.
>

I'll take another look at the code today to see if this can be resolved on the
code side.

Stefan.

On Tuesday 29 September 2009 15:36:36 Stefan Radermacher wrote:
> I traced the code trying to find out why it wouldn't load my data sets. For
> each data set defined on the CAMPAIGN line of the character the parser
>  checks the game mode defined in that data set's PCC file against the
>  current game mode. This is the condition used:
>
> aCampaign.containsInList(
>   ListKey.GAME_MODE,
>   SettingsHandler.getGame().getName()
> )
>
> As far as I can say, it only checks against the real name of the game mode.
>  In my case the current game mode was "Pathfinder_RPG", and the data sets
>  had just "Pathfinder" in them, and were not loaded because these didn't
>  match.
>
> Stefan.
>
> On Tuesday 29 September 2009 15:14:53 Eddy Anthony wrote:
> > I just saw this after I sent you a personal message about that commit,
> > now I understand why you did that. So the GAMEMODE tag needs to match
> > the gameMode folder name or it breaks the load pcc sources function? Is
> > there a way to fix this in the code rather than limit ourselves to
> > making these match? This means Legends_of_Excalibur also will have this
> > problem (GAMEMODE:LoE) and what happens when there are multiples in
> > ALOWEDMODES like in xCrawl (ALLOWEDMODES:3e|DnD|Xcrawl).
> >
> > In any case if this is the solution you need to also change the gameMode
> > file.
> >
> > Stefan Radermacher wrote:
> > > I found the problem. It happens only with Pathfinder data sets, and the
> > > error was that the PCC files still had GAMEMODE:Pathfiner, but the game
> > > mode name has changed. I'm committing a fix.
> > >
> > > Stefan.
> > >
> > > On Monday 28 September 2009 16:04:38 Stefan Radermacher wrote:
> > >> I'm having trouble loading up most of my pcg files recently. I use the
> > >>  "load sources from pcg file" mode, and the pcg file has the needes
> > >> sources listed in a CAMPAIGN tag line. This has now ceased to work, as
> > >> objects that are not defined in the first listed campaign are no
> > >> longer loaded and show up as unknown.
> > >>
> > >> Any idea what caused this?
> > >>
> > >> Regards,
> > >> Stefan.
>
> ------------------------------------
>
> Yahoo! Groups Links
>
>
>

OK, I have found this bug and fixed it locally. Can someone please create a
tracker for this, with the following text? This should be fixed for 5.16, too,
I think.

Summary:
Load sources with PC does not work with Pathfinder game mode

Description:
The option to load the sources with a PC file does not work if the internal
name of the game mode is not the same as the name listed in the source's PCC
file. For example, the internal name of the Pathfinder game mode is
"Pathfinder_RPG", while the data set has "GAMEMODE:Pathfinder" in its PCC
file. These don't match, and thus PCGen cannot load the data set with the PC
file.

Stefan.


On Wednesday 30 September 2009 08:17:48 Stefan Radermacher wrote:
> I'll take another look at the code today to see if this can be resolved on
>  the code side.
>
> Stefan.
>
> On Tuesday 29 September 2009 15:36:36 Stefan Radermacher wrote:
> > I traced the code trying to find out why it wouldn't load my data sets.
> > For each data set defined on the CAMPAIGN line of the character the
> > parser checks the game mode defined in that data set's PCC file against
> > the current game mode. This is the condition used:
> >
> > aCampaign.containsInList(
> >   ListKey.GAME_MODE,
> >   SettingsHandler.getGame().getName()
> > )
> >
> > As far as I can say, it only checks against the real name of the game
> > mode. In my case the current game mode was "Pathfinder_RPG", and the data
> > sets had just "Pathfinder" in them, and were not loaded because these
> > didn't match.
> >
> > Stefan.
> >
> > On Tuesday 29 September 2009 15:14:53 Eddy Anthony wrote:
> > > I just saw this after I sent you a personal message about that commit,
> > > now I understand why you did that. So the GAMEMODE tag needs to match
> > > the gameMode folder name or it breaks the load pcc sources function? Is
> > > there a way to fix this in the code rather than limit ourselves to
> > > making these match? This means Legends_of_Excalibur also will have this
> > > problem (GAMEMODE:LoE) and what happens when there are multiples in
> > > ALOWEDMODES like in xCrawl (ALLOWEDMODES:3e|DnD|Xcrawl).
> > >
> > > In any case if this is the solution you need to also change the
> > > gameMode file.
> > >
> > > Stefan Radermacher wrote:
> > > > I found the problem. It happens only with Pathfinder data sets, and
> > > > the error was that the PCC files still had GAMEMODE:Pathfiner, but
> > > > the game mode name has changed. I'm committing a fix.
> > > >
> > > > Stefan.
> > > >
> > > > On Monday 28 September 2009 16:04:38 Stefan Radermacher wrote:
> > > >> I'm having trouble loading up most of my pcg files recently. I use
> > > >> the "load sources from pcg file" mode, and the pcg file has the
> > > >> needes sources listed in a CAMPAIGN tag line. This has now ceased to
> > > >> work, as objects that are not defined in the first listed campaign
> > > >> are no longer loaded and show up as unknown.
> > > >>
> > > >> Any idea what caused this?
> > > >>
> > > >> Regards,
> > > >> Stefan.
> >
> > ------------------------------------
> >
> > Yahoo! Groups Links
>
> ------------------------------------
>
> Yahoo! Groups Links
>
>
>

Hi Tom,

I've just noticed that the containsAnyInList method that I'm using to fix this
in the trunk is not present in the 5.16 branch. It looks to me as if it would
not be a problem to port this method and the methods it needs to call into
5.16, too, but I wanted to check with you to see if you think there might be
problems doing that. What do you think?

Regards,
Stefan.

On Wednesday 30 September 2009 08:55:18 Stefan Radermacher wrote:
> OK, I have found this bug and fixed it locally. Can someone please create a
> tracker for this, with the following text? This should be fixed for 5.16,
>  too, I think.
>
> Summary:
> Load sources with PC does not work with Pathfinder game mode
>
> Description:
> The option to load the sources with a PC file does not work if the internal
> name of the game mode is not the same as the name listed in the source's
>  PCC file. For example, the internal name of the Pathfinder game mode is
>  "Pathfinder_RPG", while the data set has "GAMEMODE:Pathfinder" in its PCC
>  file. These don't match, and thus PCGen cannot load the data set with the
>  PC file.
>
> Stefan.
>
> On Wednesday 30 September 2009 08:17:48 Stefan Radermacher wrote:
> > I'll take another look at the code today to see if this can be resolved
> > on the code side.
> >
> > Stefan.
> >
> > On Tuesday 29 September 2009 15:36:36 Stefan Radermacher wrote:
> > > I traced the code trying to find out why it wouldn't load my data sets.
> > > For each data set defined on the CAMPAIGN line of the character the
> > > parser checks the game mode defined in that data set's PCC file against
> > > the current game mode. This is the condition used:
> > >
> > > aCampaign.containsInList(
> > >   ListKey.GAME_MODE,
> > >   SettingsHandler.getGame().getName()
> > > )
> > >
> > > As far as I can say, it only checks against the real name of the game
> > > mode. In my case the current game mode was "Pathfinder_RPG", and the
> > > data sets had just "Pathfinder" in them, and were not loaded because
> > > these didn't match.
> > >
> > > Stefan.
> > >
> > > On Tuesday 29 September 2009 15:14:53 Eddy Anthony wrote:
> > > > I just saw this after I sent you a personal message about that
> > > > commit, now I understand why you did that. So the GAMEMODE tag needs
> > > > to match the gameMode folder name or it breaks the load pcc sources
> > > > function? Is there a way to fix this in the code rather than limit
> > > > ourselves to making these match? This means Legends_of_Excalibur also
> > > > will have this problem (GAMEMODE:LoE) and what happens when there are
> > > > multiples in ALOWEDMODES like in xCrawl (ALLOWEDMODES:3e|DnD|Xcrawl).
> > > >
> > > > In any case if this is the solution you need to also change the
> > > > gameMode file.
> > > >
> > > > Stefan Radermacher wrote:
> > > > > I found the problem. It happens only with Pathfinder data sets, and
> > > > > the error was that the PCC files still had GAMEMODE:Pathfiner, but
> > > > > the game mode name has changed. I'm committing a fix.
> > > > >
> > > > > Stefan.
> > > > >
> > > > > On Monday 28 September 2009 16:04:38 Stefan Radermacher wrote:
> > > > >> I'm having trouble loading up most of my pcg files recently. I use
> > > > >> the "load sources from pcg file" mode, and the pcg file has the
> > > > >> needes sources listed in a CAMPAIGN tag line. This has now ceased
> > > > >> to work, as objects that are not defined in the first listed
> > > > >> campaign are no longer loaded and show up as unknown.
> > > > >>
> > > > >> Any idea what caused this?
> > > > >>
> > > > >> Regards,
> > > > >> Stefan.
> > >
> > > ------------------------------------
> > >
> > > Yahoo! Groups Links
> >
> > ------------------------------------
> >
> > Yahoo! Groups Links
>
> ------------------------------------
>
> Yahoo! Groups Links
>
>
>

This may sound stupid but how do I edit the tracker? I can't even find
any help on it.

thpr wrote:
>
>
> Mark,
>
> I've added you to the project on SourceForge, so please go ahead and
> commit your change.
>
> You should also be able to assign the tracker to yourself and mark
> that as implemented.
>
> Please also make sure to add your name to the code monkeys list in
> PCGenProp.properties
>
> Thanks again for the fix!
>
> TP.
>
>
> ------------------------------------------------------------------------
>
>
> No virus found in this incoming message.
> Checked by AVG - www.avg.com
> Version: 8.5.409 / Virus Database: 270.13.114/2402 - Release Date: 09/29/09
05:54:00
>
>