On Wed, 11 Jul 2001 14:23:37 +0200, "Artur Bergman" wrote:
>As soon as Perl_re_dup is finished (incoming later from AMS) this will clone a
>ll regexes to be
>thread specific. This does not put them on the pad as Sarathy suggest, putting
> the regexes
>on the pad changes semantics of perl and is rather non trivial compared to thi
>s.
>It can however be done later.
>
>Problems might be the pm flags, if so we will have to move them out of this an
>d onto a seperate list.
>I don't fully grok the flags and left them as existing. Could somone comment o
>n this?

Might some of the pm flags belong in the REGEXP rather than in the PMOP?
If so, I'd suggest moving them there.

Overall, looks like good progress (assuming re_dup() works). It will
be easy to convert the global padlist you have there into CV-specific
pad entries in future.

There appears to be a leak though. I don't see where PL_regex_padav
entries are freed when the PMOP is freed. And if such freeing creates
a hole in the PL_regex_padav, subsequent allocation of an entry from
the list should get the same offset as the freed one. (If you look
closely, doing this will pretty much reinvent the already existing
pad_alloc() and pad_free().)

Thanks.


Sarathy
gsar@...