cdunde wrote:

> One overall comment it that when the toolbar was setup it was made
> to follow the RMB pop-up menu (written by tiglari) as much as
> possible which also has these functions as individual items and from
> looking at the individual code of the functions them selves may need
> to be that way to keep from having to rewrite the function codes
> (also written by tiglari).

Sure, and that seems like a sensible way of going about it. However,
the problem is that the right-click menu is organized so that the most
commonly used functions are in the top-level menu, to make them easily
accessible. For the toolbar, however, that doesn't make sense: all
the buttons are equally accessible, and what you want is to group
_related_ functions together.

> Also it possible could also effect the active and inactive state of
> the RMB pop-up menu as well, causing items that should not be active
> to become active.
>
> So some testing should be done to verify these areas.

Thanks for the tip, I'll keep an eye on it.

> > 1. Merge "Tag side" and "Add to tagged" buttons
> >
> > At the moment there are two buttons which do the same thing: they
> > add a face to the list of tagged faces. One of them is for the
> > special case where no items are tagged, and one for the case where
> > one or more items are tagged. I propose removing the "Tag side"
> > button and making "Add to tagged" detect if nothing is tagged.
>
> These two functions use entirely different "list" of object(s)
> selected.
>
> Tag side (or TagSideClick function in the maptagside.py code file)
> uses editor.layout.explorer.sellist for its list items.
>
> Add to tagged (or addtoTaggedClick function same code file) uses
> editor.layout.explorer.uniquesel for its list items.
>
> So I would guess that some base code changing would need to be done
> there as well as to their respected "active/non-active" code for the
> RMB menu to remain correct as to weather a single or multiple (which
> means more than one) items have been tagged.

Yep, I noticed that, and checked up on it. This actually was the
thing that prompted the second e-mail. As far as I can tell, the
proper behaviour of the two functions should be as follows:

* "Tag side" should clear the current tags, and tag only a single
face.

* "Add to tagged" should tag _all_ currently selected faces, without
clearing any current tags.

The code I have now does the former correctly. I've made
modifications to the right-click menu to match.

> > 2. Make "Remove from tagged" succeed if nothing is tagged
> >
> > Fairly self-explanatory.
>
> Not sure what you mean by "succeed"? Have the button removed from
> the toolbar if nothing is tagged and reappear if something is? If
> so, how would that effect other toolbars that might follow it in
> there positioning?

No; basically, the idea is that this button (and also the right-click
menu button) should behave as follows:

* If nothing is selected, do nothing, silently (i.e. untag all
selected faces)

* If anything is selected that is _not_ a face, give a warning
message (can't untag this face, it's not a face).

* If one or more faces are selected, make sure none of them are
tagged (i.e. untag all selected faces).

This means that the _only_ time you should see a message is if you try
to untag something that isn't a face.

> > 3. Put "Glue to tagged" button with other gluing/tagging buttons
> >
> > Where it's currently located, the "Glue to tagged" button seems a
> > bit out of context. I propose placing it in the central section of
> > the toolbar with the other buttons that carry out gluing and
> > tagging operations (it would be the leftmost button).
>
> It is also the second item on the RMB pop-up menu and I think
> tiglari set it up that way because it seems to be used most common
> with the single item tagging function , the first function item, and
> you can only use it for a single tagged item, if I am not
> mistaking. So its positioning would seem correct to me (IMHO).

As I explained earlier, that makes sense on the right-click menu,
where the most commonly used functions need to be in the toplevel and
close to the top, but not on the toolbar.

> > 4. Add section for non-tagging texture tools
> >
> > At the moment, texture positioning tools which work with tags are
> > mixed in with those that don't. I propose creating a new section
> > of the toolbar containing "Mirror flip tex", "Choose
> texture", "Position
> > texture tool" and "Texture flag settings".
>
> Yes, those items and the RMB menu items are kind of mixed up with
> one another and probably should be rearranged with a separator or
> relocation of the tagging items to the tagging section.

Okay, will implement.

> > In addition, some of the tools will be renamed, and the error/hint
> > messages made more explanatory (it took me a while to work out
> > what "Mirror flip tex" was actually supposed to do; I thought it
> > should mirror _and_ flip the texture!)
>
> I can see what you mean there. It really only "mirrors" the texture,
> depending on your interpretation of what mirror and flip mean. 8-| I
> have always thought that mirroring would be like what you see if you
> look at something in a mirror, it gets reversed from side to side
> and flip would be top to bottom. If that is correct then only mirror
> should be used in its description and a new function to "flip" it
> should be created and added to the toolbar and RMB menu, I would
> think.

Likewise, will implement.

> > P.S. Many of the the tagging error messages have the word
> > "multipal" in them, which is one I've never seen before. ;)
>
> It means "more than one", like single means only one item.

I think you'll find that's spelt "multiple". What I wrote was meant
to be a joke at the expense of whoever wrote the original hints (sorry
if it was you).

> That's just my two cents, pounds, lerra worth ;-)

Thank you! Needed to bounce this stuff off someone. ;)

Peter

--
Quake II build tools: http://peter-b.co.uk/
Latest QuArK: http://quark.sourceforge.net/LatestVersion

v2sw6YShw7ln5pr6ck3ma8u7Lw3+2m0l7CFi6e4+8t4Eb8Aen4g6Pa2Xs5MSr5p4
hackerkey.com