Re: Very bad smell in MSVCRT (Was: Re: Details of the crash caused by "language messages zh_CN.UTF-8")
Yongwei wrote:
> >> I am mentioning this again, because I applied the following patch in
> >> May and have not encountered any problems since then (only _WIN32 is
> >> tested). Maybe it can be accepted now?
> >>
> >>
> ========================================================================
> >> --- main.c.orig Mon Sep 26 13:49:52 2005
> >> +++ main.c Mon Sep 26 14:04:18 2005
> >> @@ -218,6 +218,9 @@
> >> * work until set_init_1() has been called!
> >> */
> >> setlocale(LC_ALL, "");
> >> +#if defined(_WIN32) || defined(_WIN64)
> >> + setlocale(LC_CTYPE, "C");
> >> +#endif
> >>
> >> # ifdef FEAT_GETTEXT
> >> {
> >>
> ========================================================================
> >
> > OK, let's include it now and await any problem reports.
> >
> > For completeness this also has to be added, for the ":language"
> > command:
> >
> > [snipped]
>
> Hi, Bram, I did not see an official patch appear regarding this issue,
> so I am asking here again. Do you think it good enough now? Can it
> enter 6.4?
>
> I have currently the patch applied as attached --- in case you forgot
> where you put your old and unapplied patches :-). No problems are found
> and everything is OK.
This is a change in Vim 7, it has been included in the latest
snapshots.
I don't want to include this in Vim 6.4, the risk that it breaks
something is too big.
--
BEDEVERE: And that, my lord, is how we know the Earth to be banana-shaped.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --
Bram@... --
http://www.Moolenaar.net \\\
/// Sponsor Vim, vote for features --
http://www.Vim.org/sponsor/ \\\
\\\ Project leader for A-A-P --
http://www.A-A-P.org ///
\\\ Buy LOTR 3 and help AIDS victims --
http://ICCF.nl/lotr.html ///