Note that XML::FeedPP version 0.36 was released.

========
2008/10/26 (0.36)
     * RFC1123 and RSS spec allow two-digit date format
       http://rt.cpan.org/Public/Bug/Display.html?id=36890
       http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503260
       (thanks to Illtud Daniel and Anthony DeRobertis)
========

Thank you both.

---------- Forwarded message ----------
From: Kawasaki Yusuke <u-suke@...>
Date: Sun, Oct 26, 2008 at 1:37 PM
Subject: Re: XML::FeedPP -- two-digit years
To: Adrian von Bidder
Cc: 503260@...


Hi Adrian,

Now XML::FeedPP allows two-digit date format.
Thanks to Illtud Daniel and Anthony DeRobertis.
http://rt.cpan.org/Public/Bug/Display.html?id=36890
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503260

I've also added a test code for Anthony's patch.
Version 0.36 updated will be soon available on CPAN:
http://search.cpan.org/dist/XML-FeedPP/

Or directly get it from my website:
http://www.kawa.net/works/perl/feedpp/feedpp-e.html

--
Kawasaki Yusuke
http://www.kawa.net/



On Fri, Oct 24, 2008 at 5:44 PM, Adrian von Bidder wrote:
> Hi,
>
> I'm Adrian von Bidder, a Debian developer, and I have created a Debian
> package of XML::FeedPP a while ago.
>
> A fellow Debian user has noticed that FeedPP doesn't support two-digit years
> (the RFC1123 standard says it should), and has written a bug report
> including patch against 0.34 at <http://bugs.debian.org/503260>
>
> I'll update the Debian package to 0.35 in the near future, but I guess I'll
> adapt the patch to work with 0.35 (and add it to the bug report).  I'd be
> happy if you could consider adding it (or some other equivalent
> modification) to the next FeedPP version as well.
>
> cheers
> -- vbi
>
> --
> You are what you see.


On Sat, Jun 21, 2008 at 2:54 AM, Illtud Daniel via RT
<bug-XML-FeedPP@...> wrote:
> Fri Jun 20 13:54:17 2008: Request 36890 was acted upon.
>       Queue: XML-FeedPP
>     Subject: XML::FeedPP doesn't seem to accept two-digit date format
>   Broken in: (no value)
>    Severity: (no value)
>       Owner: Nobody
>      Status: new
>  Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=36890 >
>
>
> XML::FeedPP version 0.35 doesn't seem to handle a two-digit date
> format (eg 08 for 2008) in the pubDate field of RSS.
>
> The RSS spec says that although a 4-digit year is preferable,
> a two digit field is OK.
>
> eg,
> <pubDate>Tue, 26 Aug 08 11:00:00 GMT</pubDate>
>
> comes out as:
>
> 0008-08-26T11:00:00Z
>
> instead of:
>
> 2008-08-xxxx
>
> --
> Illtud Daniel
> Uwch Ddadansoddwr Systemau                       Senior Systems Analyst
> Llyfrgell Genedlaethol Cymru                  National Library of Wales
> Yn siarad drosof fy hun, nid LlGC   -  Speaking personally, not for NLW

XML::FeedPP version 0.37 was shipped.

http://search.cpan.org/dist/XML-FeedPP/
http://www.kawa.net/works/perl/feedpp/dist/XML-FeedPP-0.37.tar.gz
http://xml-treepp.googlecode.com/svn/trunk/XML-FeedPP/Changes

2009/01/18 (0.37)
     * fixed #42472: items with 2 titles break the parser
       (thanks to thaabit)
       http://rt.cpan.org/Public/Bug/Display.html?id=42472
     * fixed #41771: possible bug in $item->guid
       (thanks to PriggeScottM)
       http://rt.cpan.org/Public/Bug/Display.html?id=41771

--
Kawasaki Yusuke
http://www.kawa.net/

I'm trying to use the following feed with FeedPP:

http://thesteampunkhome.blogspot.com/feeds/posts/default

     Which is an Atom feed.  It seems to parse correctly, however if I call a
line like:

print "Category: ", $item->category(), "\n";

     Perl throughs the following error:

Not an ARRAY reference at /usr/lib/perl5/site_perl/5.8.8/XML/FeedPP.pm line
2107.

     I see in the docs, category() is supposed to be ignored for Atom feeds, but
that doesn't seem to happen.

     All the other item calls are fine, it just seems to be category that fails.

                                     Greg

XML::FeedPP::RSS::Item supports ->image() method which works counter-standard
(<image> tag is not supported inside items in RSS 2.0).

While this is OK to parse non standard conformant feeds, issuing ->image() with
arguments creates a broken RSS 2.0 feed.

The standard (in RSS 2.0) mean to associate an image with an item is to use
<enclosure/> tag.

I am going to rewrite (and send the patch) XML::FeedPP to be able to parse feeds
with images attached to items.

The issue is whether I should change XML::FeedPP::RSS::Item->image() invoked
with arguments to generate <enclosure/> tag or leave
XML::FeedPP::RSS::Item->image() as is, just deprecating it in favor of some new
method which will be standard conformant?

I await the reply of Kawasaki.

--- In xml-feedpp@yahoogroups.com, "whitbygreg" <greg@...> wrote:
>
>     I'm trying to use the following feed with FeedPP:
>
> http://thesteampunkhome.blogspot.com/feeds/posts/default
>
>     Which is an Atom feed.  It seems to parse correctly, however if I call a
line like:

It is not an Atom feed. It is an RSS 2.0 feed with (strangely) included Atom
tags.

> print "Category: ", $item->category(), "\n";
>
>     Perl throughs the following error:
>
> Not an ARRAY reference at /usr/lib/perl5/site_perl/5.8.8/XML/FeedPP.pm line
2107.

I confirm the bug and will work on the patch.

Hi all

I've just released version 0.38 to fix the problem bertl's reported:
http://rt.cpan.org/Public/Bug/Display.html?id=36270

And now I added Victor as a project member on Google Code:
http://code.google.com/p/xml-treepp/

I need all your helps to maintain the modules.
If anybody want a svn commit bit, let me know that.

Thanks anyway.

-- Yusuke Kawasaki

On Thu, Mar 12, 2009 at 12:07 AM, Victor Porton <porton@...> wrote:
> XML::FeedPP::RSS::Item supports ->image() method which works counter-standard
(<image> tag is not supported inside items in RSS 2.0).
>
> While this is OK to parse non standard conformant feeds, issuing ->image()
with arguments creates a broken RSS 2.0 feed.
>
> The standard (in RSS 2.0) mean to associate an image with an item is to use
<enclosure/> tag.
>
> I am going to rewrite (and send the patch) XML::FeedPP to be able to parse
feeds with images attached to items.
>
> The issue is whether I should change XML::FeedPP::RSS::Item->image() invoked
with arguments to generate <enclosure/> tag or leave
XML::FeedPP::RSS::Item->image() as is, just deprecating it in favor of some new
method which will be standard conformant?
>
> I await the reply of Kawasaki.

It seems that this bug disappeared with 0.38 release.

--- In xml-feedpp@yahoogroups.com, "whitbygreg" <greg@...> wrote:
>
>     I'm trying to use the following feed with FeedPP:
>
> http://thesteampunkhome.blogspot.com/feeds/posts/default
>
>     Which is an Atom feed.  It seems to parse correctly, however if I call a
line like:
>
> print "Category: ", $item->category(), "\n";
>
>     Perl throughs the following error:
>
> Not an ARRAY reference at /usr/lib/perl5/site_perl/5.8.8/XML/FeedPP.pm line
2107.
>
>     I see in the docs, category() is supposed to be ignored for Atom feeds,
but that doesn't seem to happen.
>
>     All the other item calls are fine, it just seems to be category that
fails.
>
>                                     Greg
>

Currently ->category() returns either the category name or an array of category
names. (Am I right?) The @domain attribute is lost.

Personally I now don't need the @domain attribute but indeed I suggest to
discuss whether @domain should be somehow and somewhere returned.

> Currently ->category() returns either the category name or an array of
category names. (Am I right?)

Right. It returns either the category name or an array reference of
category names.
See 34_category_type.t:

         <item>
             <link>http://www.example.com/4.html</link>
             <category type="e">cate_e</category>
             <category domain="f">cate_f</category>
         </item>

     my $cate3 = $item3->category;
     ok( ref $cate3, '3: multiple with attribute / ref' );
     is( (scalar @$cate3), 2, '3: multiple with attribute / num' );
     is( $cate3->[0], 'cate_e', '3: multiple with attribute / val e' );
     is( $cate3->[1], 'cate_f', '3: multiple with attribute / val f' );

It doesn't return an array due to backward compatibility, unfortunately.

     my @cate3 = $item3->category;   # not work


> The @domain attribute is lost.
> Personally I now don't need the @domain attribute but indeed I suggest to
discuss whether @domain should be somehow and somewhere returned.

To fetch @domain attribute, we can use get() method at this time.

     my $doma3 = $item3->get( 'category@domain' );
     is( $doma3, 'f', '3: multiple with attribute / domain' );

I've committed version 0.39 which fixes a bug for fetching attributes
in multiple elements.
http://xml-treepp.googlecode.com/svn/trunk/XML-FeedPP/lib/XML/FeedPP.pm
http://xml-treepp.googlecode.com/svn/trunk/XML-FeedPP/t/36_get_multiple.t
This is not CPANed yet.

There are no way to set @domain attribute in multiple <category>
elements however.

--
Kawasaki Yusuke
http://www.kawa.net/

The XML::FeedPP::RSS::Item->image() method (about which I've complained that
this is counter-standard in a previous post in this group) is only a getter (not
a setter), it is not able to add image to a feed.

I have started development of item enclosures and item images in new
/svn/branches/enclosures/ branch.

It is OK for now to create methods which could be only getters (not a setters)
and leave it for somebody's further development to transform these to full
featured setters?

Personally I now don't need the ability to create new RSS feeds, but only to
parse existing (however in the future I may probably need this).

Huh?

Oh, sorry for a stupid thing, now I noticed that XML::FeedPP::RSS::Item->image()
method indeed is a setter. I was uncareful.

--- In xml-feedpp@yahoogroups.com, "Victor Porton" <porton@...> wrote:
>
> The XML::FeedPP::RSS::Item->image() method (about which I've complained that
this is counter-standard in a previous post in this group) is only a getter (not
a setter), it is not able to add image to a feed.
>
> I have started development of item enclosures and item images in new
/svn/branches/enclosures/ branch.
>
> It is OK for now to create methods which could be only getters (not a setters)
and leave it for somebody's further development to transform these to full
featured setters?
>
> Personally I now don't need the ability to create new RSS feeds, but only to
parse existing (however in the future I may probably need this).
>
> Huh?

get_set_array() called with last undef element does not reset the array to
become zero-element, but just returns the value of the array.

What if I would want to remove all <category> elements from a RSS 2.0 feed?
XML::FeedPP does not provide a method for this.

Even if I pass a zero-length array to get_set_array() it does not remove the
element from the hash.

I suggest that get_set_array() called with a zero-length array as the last
argument should remove the key from the hash.

I could modify the trunk in SVN so that get_set_array() called with a
zero-length array would behave this way, but before this I ask the permission
and agreement of Kawasaki.

Huh, Kawasaki?

When I run "make test" all tests fail with the messages like:

Can't locate object method "new" via package "XML::FeedPP" (perhaps you forgot
to load "XML::FeedPP"?) at t/36_get_multiple.t line 33.

What is the correct way to run tests?! Or maybe we need a bugfix for our tests.
I don't know what to do with this.

This was a bug in ExtUtils::MakeMaker. It wrongly handles directories with
colons (':').

--- In xml-feedpp@yahoogroups.com, "Victor Porton" <porton@...> wrote:
>
> When I run "make test" all tests fail with the messages like:
>
> Can't locate object method "new" via package "XML::FeedPP" (perhaps you forgot
to load "XML::FeedPP"?) at t/36_get_multiple.t line 33.
>
> What is the correct way to run tests?! Or maybe we need a bugfix for our
tests. I don't know what to do with this.
>

I can confirm that 0.38 fixes the issue, the README file indicates the fix
was included.  Thanks for looking at it.

                                   Greg

--- In xml-feedpp@yahoogroups.com, "Victor Porton" <porton@...> wrote:
>
> It seems that this bug disappeared with 0.38 release.
>
> --- In xml-feedpp@yahoogroups.com, "whitbygreg" <greg@> wrote:
> >
> >     I'm trying to use the following feed with FeedPP:
> >
> > http://thesteampunkhome.blogspot.com/feeds/posts/default
> >
> >     Which is an Atom feed.  It seems to parse correctly, however if I call a
line like:
> >
> > print "Category: ", $item->category(), "\n";
> >
> >     Perl throughs the following error:
> >
> > Not an ARRAY reference at /usr/lib/perl5/site_perl/5.8.8/XML/FeedPP.pm line
2107.
> >
> >     I see in the docs, category() is supposed to be ignored for Atom feeds,
but that doesn't seem to happen.
> >
> >     All the other item calls are fine, it just seems to be category that
fails.
> >
> >                                     Greg
> >
>

I just finished the development of ->enclosure() method for items. Lastly I
wrote tests (which discovered some bugs which I fixed).

The yet planned thing is to add support for item images.

I doubt whether to create new branch for images or to use the existing
"enclosures" branch. (I'm a novice in Subversion version tracking.)

Kawasaki, please guide when we will run "svn merge --reintegrate"? Should we
already reintegrate ->enclosure() stuff into the trunk or we should wait for
better testing than that I do in t/37_enclosure.t?

Kawasaki, it is important that you answer this question, as only you can
properly guide development of XML::FeedPP (whether to reintegrate now).

/svn/trunk
     \-/svn/branches/enclosures
         \-/svn/branches/images

Trunk is the trunk.

"enclosures" is finished but maybe not enough tested support for item
enclosures. Should we reintegrate it into the trunk now?

"images" is the branch for planned item images. As for this moment "images" is
the exact copy of "enclosures" (no changes yet).

Why "sub image" in XML::FeedPP uses <link rel="icon">?

This contradicts to Atom 0.3 specification and is not defined in Atom 1.0
specification.

Atom 0.3 defines no mean to define channel's image, Atom 1.0 defines <atom:logo>
and <atom:icon> elements. I think <atom:logo> should be used in this case.

Kawasaki, Is it OK that I could edit the trunk in SVN? Please reply.

I reintegrated support of item enclosures and item images into svn/trunk.

Enjoy. Test.

When we will make the next official release?

Victor,

Thanks for your nice work.
I don't think XML::FeedPP's multimedia support is best at this time,
so it could be help many users.

I was away last week to go some conferences in Japan.
I'm sorry for late to reply messages.
And now, this weekend, I have time and some questions.

1.
xmlns:enc="" and xmlns:image="" namespace attributes are
always added on <rdf:RDF> root element.
Is there any other way to avoid such changes?
By updating the module by cpan,
I think the feed document generated must not be changed
except for case of security reasons or so.
Most users didn't use the namespaces yet.
ie. local $XML::FeedPP::RDF::ENCLOSURE = 1;
would be a solution. It's not cool however...

2.
attached_image() method is available for all formats?
38_item_image.t seems to test it only for XML::FeedPP::RDF.

3.
enclosure() method is available for all formats except for Atom 0.3?
37_enclosure.t seems to test it only for XML::FeedPP::RSS.

Could you add tests covered?

http://rt.cpan.org/Public/Bug/Display.html?id=44082
I'll work for it.

Regards,

--- Yusuke Kawasaki

On Sat, Mar 21, 2009 at 2:46 AM, Victor Porton <porton@...> wrote:
> I reintegrated support of item enclosures and item images into svn/trunk.
>
> Enjoy. Test.
>
> When we will make the next official release?

--- In xml-feedpp@yahoogroups.com, Kawasaki Yusuke <u-suke@...> wrote:
>
> 1.
> xmlns:enc="" and xmlns:image="" namespace attributes are
> always added on <rdf:RDF> root element.
> Is there any other way to avoid such changes?

You know better. I just noticed that there was "dc" namespace prefix and added
"enc" and "image" nearby (blindly acting by analogy).

If you think these should be removed or altered in some way, do whatever you
consider right.

> By updating the module by cpan,
> I think the feed document generated must not be changed
> except for case of security reasons or so.
> Most users didn't use the namespaces yet.
> ie. local $XML::FeedPP::RDF::ENCLOSURE = 1;
> would be a solution. It's not cool however...

Saying "document generated must not be changed" you refer to my added namespaces
or what?

$XML::FeedPP::RDF::ENCLOSURE = 1; would be a really poor solution.

Maybe you will explain me how namespaces work in XML::FeedPP and XML::TreePP. I
simply don't know, I was acting by analogy with "dc".

> 2.
> attached_image() method is available for all formats?
> 38_item_image.t seems to test it only for XML::FeedPP::RDF.

Read the man page. Setting attached image currently work only for RDF. Getting
attached image works for all except Atom 3.0. In non-RDF formats getting it
simply returns an enclosure with matching content type (e.g. image/jpeg).

> 3.
> enclosure() method is available for all formats except for Atom 0.3?
> 37_enclosure.t seems to test it only for XML::FeedPP::RSS.

37_enclosure.t calls test_feed() for all feed types except Atom 3.0. So some
tests are run for several feed types not only XML::FeedPP::RSS.

> Could you add tests covered?

I don't know what to add.

> http://rt.cpan.org/Public/Bug/Display.html?id=44082
> I'll work for it.

I don't understand why you've given me this URL. Just to note?

> On Sat, Mar 21, 2009 at 2:46 AM, Victor Porton <porton@...> wrote:
> > I reintegrated support of item enclosures and item images into svn/trunk.
> >
> > Enjoy. Test.
> >
> > When we will make the next official release?
>

Hey Vicror,

I mean we need care more for users.
I would not like to change the default behavior in the minor updates.

You must know that many users are already using this module
which does not add xmlns:enc and xmlns:image on RDF by default.
Your change could fail tests of other modules/applications
which depend on this module.

Could you please let me see any other ideas to make it without changes.
There would be several ways to do that.

> I simply don't know, I was acting by analogy with "dc".

I mean "dc" is enough popular and the module have supported it for three years.
Most of the current users expect that "dc" is available and "enc" is not.
Still you could refer code for "dc" however.

>> http://rt.cpan.org/Public/Bug/Display.html?id=44082
>> I'll work for it.
> I don't understand why you've given me this URL. Just to note?

Right. It's just a note. Then I've worked for it.
http://code.google.com/p/xml-treepp/source/diff?r=69&path=/trunk/XML-FeedPP/lib/\
XML/FeedPP.pm
I have another note for you to see the authors section above.

Thanks.

--- Yusuke Kawasaki

Hello Kawasaki,

I don't know how namespaces work in XML::TreePP. Could you explain?

--- In xml-feedpp@yahoogroups.com, Kawasaki Yusuke <u-suke@...> wrote:
>
> Hey Vicror,
>
> I mean we need care more for users.
> I would not like to change the default behavior in the minor updates.
>
> You must know that many users are already using this module
> which does not add xmlns:enc and xmlns:image on RDF by default.
> Your change could fail tests of other modules/applications
> which depend on this module.

Hi Victor,

XML::TreePP module does nothing about namespaces actually.
xmlns:rdf="" is treated just an attribute in root element.
The module never validate namespaces used in an XML document.
Users of the module must care for it if needed.

Does this help you?

Thanks,

---
Yusuke Kawasaki

On Sun, Mar 22, 2009 at 12:37 AM, Victor Porton <porton@...> wrote:
> Hello Kawasaki,
>
> I don't know how namespaces work in XML::TreePP. Could you explain?
>
> --- In xml-feedpp@yahoogroups.com, Kawasaki Yusuke <u-suke@...> wrote:
>>
>> Hey Vicror,
>>
>> I mean we need care more for users.
>> I would not like to change the default behavior in the minor updates.
>>
>> You must know that many users are already using this module
>> which does not add xmlns:enc and xmlns:image on RDF by default.
>> Your change could fail tests of other modules/applications
>> which depend on this module.

XML::FeedPP version 0.40 was released.

http://www.kawa.net/works/perl/feedpp/feedpp-e.html
http://search.cpan.org/dist/XML-FeedPP/
http://xml-treepp.googlecode.com/svn/trunk/XML-FeedPP/lib/XML/FeedPP.pm

2009/04/07 (0.40)
     * fixed #44082: parse method refuses feeds with UTF-8 BOM
       http://rt.cpan.org/Public/Bug/Display.html?id=44082
       (thanks to haarg)
     * supports to get attributes in multiple elements determinably.
       See 36_get_multiple.t
     * new() and load() methods accept -type argument to specify source type.
       http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=504143
       (thanks to Anthony DeRobertis)
     * to_string() and to_file() methods accept options for XML::TreePP.

Note that adding enclosure() method was canceled at once for the release.
Thanks.

--
Kawasaki Yusuke
http://www.kawa.net/

Hi Haidut,

I got another error "Loading failed" with XML::FeedPP v0.40.
In the case, it seems that it need more time to be connected.
Try with timeout option for XML::TreePP.

my $url = "http://rss.xinhuanet.com/rss/english/english_health.xml";
my $feed = XML::FeedPP->new($url,timeout=>60);

I hope this will help you.

--
Kawasaki Yusuke
http://www.kawa.net/

On Wed, Apr 8, 2009 at 7:11 AM, Haidut wrote:
> Yusuke,
>
> After the patch was applied the module is working better but I still get
> errors sometimes. For example this feed still gives "Invalid feed source
> error":
> http://rss.xinhuanet.com/rss/english/english_health.xml
>
> Could you please take a look to see why I get an error? My browser feed
> reader parses the feed without any problems.
> Thanks.

You are invited to join my social network, check my friends list here:
http://stobosky.zoomshare.com/files/myphoto.htm

I created the branch which will hold changes incompatibly adding namespaces (and
xmlns:*="..." attributes).

The branch URL is:
https://xml-treepp.googlecode.com/svn/branches/with-additional-namespaces/XML-Fe\
edPP

Currently the branch contains support for item enclosures and (limited) support
for item images.

In the branch
http://xml-treepp.googlecode.com/svn/branches/with-additional-namespaces/XML-Fee\
dPP

added $item->summary and $item->content methods (SVN revision 82).

Old vague $item->description is now considered deprecated.

Note that it is done in the above mentioned branch instead of the trunk because
I incompatibly introduce new namespaces 'content' and 'xhtml'.

For backward compatibility handling of $item->description is different for Atom
items and items of other feed types. Because of this item's description changes
when copying an item from an Atom to a different feed type or vice versa. This
is considered a bugfix. (Previously such item copying was changing item's
semantics replacing item's summary with item's content or vice versa. This is
considered as a bug, which is fixed.)

--- In xml-feedpp@yahoogroups.com, "Victor Porton" <porton@...> wrote:
> In the branch
>
http://xml-treepp.googlecode.com/svn/branches/with-additional-namespaces/XML-Fee\
dPP
>
> added $item->summary and $item->content methods (SVN revision 82).

My $item->content was intended to support (among of <content:encoded>) also
<xhtml:body>. But now I noticed that <xhtml:body> should contain proper XML (not
</> encoded XML like <content:encoded>).

Example:

<xhtml:body>
   <p>First paragraph</p>
</xhtml:body>

Can we implement this (injection of XML) inside an element?

I ask (especially Kawasaki Yusuke) whether it is possible with XML::TreePP.

Or we should for now just drop attempted support of xhtml:body?